cloud-fan commented on code in PR #50937:
URL: https://github.com/apache/spark/pull/50937#discussion_r2103007477


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/AlterNamespaceSetPropertiesSuiteBase.scala:
##########
@@ -110,8 +110,11 @@ trait AlterNamespaceSetPropertiesSuiteBase extends 
QueryTest with DDLCommandTest
           assert(getProperties(ns) === "", s"$key is a reserved namespace 
property and ignored")
           val meta = spark.sessionState.catalogManager.catalog(catalog)
             .asNamespaceCatalog.loadNamespaceMetadata(namespace.split('.'))
-          assert(!meta.get(key).contains("foo"),
-            "reserved properties should not have side effects")
+          val containsFoo = Option(meta.get(key)) match {

Review Comment:
   why this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to