cloud-fan commented on code in PR #50937:
URL: https://github.com/apache/spark/pull/50937#discussion_r2100217052
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##########
@@ -408,10 +408,12 @@ private[hive] class HiveClientImpl(
Option(shim.getDatabase(client, dbName)).map { d =>
val params =
Option(d.getParameters).map(_.asScala.toMap).getOrElse(Map()) ++
Map(PROP_OWNER -> shim.getDatabaseOwnerName(d))
+ val collation = params.get(PROP_COLLATION)
CatalogDatabase(
name = d.getName,
description = Option(d.getDescription).getOrElse(""),
+ collation = collation,
Review Comment:
It seems to me that this new field only brings troubles, not benefits. Hive
database does not have this field, so we need to turn it into a property
anyway. We only have one place to access this field, and we can simply get
collation property and not have this field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
