PetarVasiljevic-DB commented on code in PR #50921: URL: https://github.com/apache/spark/pull/50921#discussion_r2097745052
########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala: ########## @@ -573,6 +701,13 @@ case class ScanBuilderHolder( var pushedAggregate: Option[Aggregation] = None var pushedAggOutputMap: AttributeMap[Expression] = AttributeMap.empty[Expression] + + var joinedRelations: Seq[DataSourceV2RelationBase] = Seq() Review Comment: Yes, we can reuse `joinedRelations.isEmpty` instead of `isJoinPushed`. I will do that change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
