PetarVasiljevic-DB commented on code in PR #50921:
URL: https://github.com/apache/spark/pull/50921#discussion_r2097734078
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java:
##########
@@ -174,6 +178,12 @@ protected String visitNamedReference(NamedReference
namedRef) {
return namedRef.toString();
}
+ protected String visitJoinColumn(JoinColumn column) {
Review Comment:
> the implementations must provide the left/right side alias as a context,
in order to generate the column name.
not really.. The way I designed this is that you are already going to have
left/right side alias in JoinColumn before visiting it. So I think this
implementation is valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
