cloud-fan commented on code in PR #50918: URL: https://github.com/apache/spark/pull/50918#discussion_r2097456525
########## sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala: ########## @@ -578,6 +578,19 @@ abstract class JdbcDialect extends Serializable with Logging { */ def isCascadingTruncateTable(): Option[Boolean] = None + /** + * Attempts to determine if the given SQLException is a SQL syntax error. + * + * This check is best-effort: it may not detect all syntax errors across all JDBC dialects. + * However, if this method returns true, the exception is guaranteed to be a syntax error. + * + * This is used to decide whether to wrap the exception in a more appropriate Spark exception. + * + * @return true if the exception is confidently identified as a syntax error; false otherwise. + */ + @Since("4.0.0") Review Comment: ```suggestion @Since("4.1.0") ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org