AnishMahto commented on code in PR #50875:
URL: https://github.com/apache/spark/pull/50875#discussion_r2093435763
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala:
##########
@@ -37,9 +37,14 @@ import org.apache.spark.sql.streaming.{GroupStateTimeout,
OutputMode}
*/
object UnsupportedOperationChecker extends Logging {
- def checkForBatch(plan: LogicalPlan): Unit = {
+ def checkForBatch(plan: LogicalPlan, isSqlContext: Boolean): Unit = {
Review Comment:
> Since there is existing SQLContext
Could you clarify what you mean by this?
Thinking about this more though, I think it still makes sense to show the
`Queries with streaming sources must be executed with writeStream.start()`
suggestion even if this is a SQL query (i.e query is being executed in a sql
context), and additionally suggest an alternative that is to execute the
streaming query with a pipeline - will make this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
