szehon-ho commented on code in PR #50701:
URL: https://github.com/apache/spark/pull/50701#discussion_r2082625385
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2DataFrameSuite.scala:
##########
@@ -438,6 +439,47 @@ class DataSourceV2DataFrameSuite
}
}
+ test("alter table with complex foldable default values") {
Review Comment:
@LuciferYang i discussed offline with @aokolnychyi , looks like its expected
because Catalyst => V2Expression conversion is only enabled for many operators,
if ANSI is enabled. I think, V2Expression is used for table format like
Iceberg, so it only make sense to accept ANSI and not Spark dialect. I made
the test fix in https://github.com/apache/spark/pull/50851, if you want to take
a look if it solves it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
