szehon-ho commented on code in PR #50701: URL: https://github.com/apache/spark/pull/50701#discussion_r2080088084
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ########## @@ -875,15 +875,18 @@ trait CheckAnalysis extends LookupCatalog with QueryErrorsBase with PlanToString !o.isInstanceOf[CollectMetrics] && !o.isInstanceOf[Filter] && !o.isInstanceOf[Aggregate] && + // The rule above is used to check Aggregate operator. Review Comment: This comment previously added in https://github.com/apache/spark/commit/e0701c75601c43f69ed27fc7c252321703db51f2 and it seemed to refer to Aggregate operator, and got out of sync with the call, so putting it back (although tbh its not a super helpful comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org