cloud-fan commented on code in PR #50701:
URL: https://github.com/apache/spark/pull/50701#discussion_r2077133426


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/ColumnDefinition.scala:
##########
@@ -164,6 +164,17 @@ object ColumnDefinition {
           }
         }
 
+      case cmd: AddColumns if cmd.columnsToAdd.exists(_.default.isDefined) =>
+        // Wrap analysis errors for default values in a more user-friendly 
message.
+        cmd.columnsToAdd.foreach { c =>
+          c.default.foreach { d =>
+            if (!d.resolved) {

Review Comment:
   shall we call `validateDefaultValueExpr`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to