cloud-fan commented on code in PR #50701:
URL: https://github.com/apache/spark/pull/50701#discussion_r2077127826
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -1022,13 +1022,25 @@ trait CheckAnalysis extends LookupCatalog with
QueryErrorsBase with PlanToString
}
}
+ def checkExistsDefaultDeterministic(colsToAdd: Seq[QualifiedColType]):
Unit = {
+ colsToAdd.foreach { col =>
+ col.default.foreach { d =>
+ if (!d.deterministic) {
+ throw QueryCompilationErrors.defaultValueNotConstantError(
Review Comment:
but the check is for deterministic, not constant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
