HeartSaVioR commented on code in PR #50780:
URL: https://github.com/apache/spark/pull/50780#discussion_r2076660267
##########
sql/api/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryListener.scala:
##########
@@ -146,14 +156,17 @@ object StreamingQueryListener extends Serializable {
* User-specified name of the query, null if not specified.
* @param timestamp
* The timestamp to start a query.
+ * @param jobTags
+ * The job tags that have been assigned to all the jobs started by this
thread
* @since 2.1.0
*/
@Evolving
class QueryStartedEvent private[sql] (
val id: UUID,
val runId: UUID,
val name: String,
- val timestamp: String)
+ val timestamp: String,
+ val jobTags: Set[String] = Set())
Review Comment:
Do we have MiMa check for this class? If this is not binary compatible, it'd
be ideal to let linter to fail.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala:
##########
@@ -288,7 +288,14 @@ abstract class StreamExecution(
// `postEvent` does not throw non fatal exception.
val startTimestamp = triggerClock.getTimeMillis()
postEvent(
- new QueryStartedEvent(id, runId, name,
progressReporter.formatTimestamp(startTimestamp)))
+ new QueryStartedEvent(
+ id,
+ runId,
+ name,
+ progressReporter.formatTimestamp(startTimestamp),
+ sparkSession.sparkContext.getJobTags()
Review Comment:
How many elements are we anticipating to have here? The size of event should
be considerably small enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
