anishshri-db commented on code in PR #50780:
URL: https://github.com/apache/spark/pull/50780#discussion_r2071901398
##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQueryListenerSuite.scala:
##########
@@ -262,12 +262,28 @@ class StreamingQueryListenerSuite extends StreamTest with
BeforeAndAfter {
assert(newEvent.id === event.id)
assert(newEvent.runId === event.runId)
assert(newEvent.name === event.name)
+ assert(newEvent.timestamp === event.timestamp)
+ assert(newEvent.jobTags === event.jobTags)
}
testSerialization(
- new QueryStartedEvent(UUID.randomUUID, UUID.randomUUID, "name",
"2016-12-05T20:54:20.827Z"))
+ new QueryStartedEvent(
+ UUID.randomUUID,
+ UUID.randomUUID,
+ "name",
+ "2016-12-05T20:54:20.827Z",
+ Set()
+ )
+ )
testSerialization(
- new QueryStartedEvent(UUID.randomUUID, UUID.randomUUID, null,
"2016-12-05T20:54:20.827Z"))
+ new QueryStartedEvent(
+ UUID.randomUUID,
+ UUID.randomUUID,
+ null,
+ "2016-12-05T20:54:20.827Z",
+ Set("tag1", "tag2")
Review Comment:
Can we add a test to confirm that the tags can be retrieved from an actual
spark context through a streaming query run ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
