vrozov commented on code in PR #50790:
URL: https://github.com/apache/spark/pull/50790#discussion_r2075583636
##########
sql/hive/pom.xml:
##########
@@ -199,6 +199,10 @@
<artifactId>scalacheck_${scala.binary.version}</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.maven.shared</groupId>
+ <artifactId>maven-invoker</artifactId>
Review Comment:
It is necessary to build jar and not only compile Java class. Calling
`javac` directly would require all the dependencies and without Maven it would
be necessary to load them.
Using maven invoker here only impacts how test jar is built. It works both
with Spark Maven and SBT builds and does not require usage of one over the
other to build Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
