pan3793 commented on code in PR #50790:
URL: https://github.com/apache/spark/pull/50790#discussion_r2074795398
##########
sql/hive/pom.xml:
##########
@@ -199,6 +199,10 @@
<artifactId>scalacheck_${scala.binary.version}</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.maven.shared</groupId>
+ <artifactId>maven-invoker</artifactId>
Review Comment:
Seems too overkill to use Maven here, how about calling `javac` directly?
https://github.com/apache/hive/blob/2d1405e7feed176aeed337581292b8438cf13326/common/src/java/org/apache/hive/common/util/HiveTestUtils.java#L94
Some additional backgrounds: there were some complains that Spark use two
building tools, Maven and SBT, which introduces additional complex to align
those behaviors, there is a chance that one of the building tools might be
dropped someday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
