mridulm commented on code in PR #50630: URL: https://github.com/apache/spark/pull/50630#discussion_r2072322347
########## core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala: ########## @@ -2337,10 +2344,8 @@ private[spark] class DAGScheduler( "checkpointing the RDD before repartition and try again." } - activeJobs.foreach(job => collectStagesToRollback(job.finalStage :: Nil)) - // The stages will be rolled back after checking - val rollingBackStages = HashSet[Stage](mapStage) + val rollingBackStages = HashSet[Stage]() Review Comment: We will end up calling `findMissingPartitions` for the mapStage, when we know it will have missing partitions. That would be an improvement to consider. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org