mridulm commented on PR #50630: URL: https://github.com/apache/spark/pull/50630#issuecomment-2826383318
> @mridulm regarding option 2 why a return is enough here (and not an abortStage): It should result in same behavior (all jobs, this stage was part of, have been aborted in that scenario - and we have not added the stage to the runningStages yes). Having said that, it is indeed better to explictly abort it - even if it does not do much right now : so that we are more robust to code evolution in future. > Why we need to check whether all jobs should be aborted and not only just one, here: Stage can be part of multiple concurrent jobs, and not all of them might be getting aborted: some of them might not have started a result stage, and so recoverable. Only if all of them have been aborted, we can abort the stage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
