peterpashkin commented on code in PR #50605:
URL: https://github.com/apache/spark/pull/50605#discussion_r2071701832
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectAnalyzeHandler.scala:
##########
@@ -61,21 +64,24 @@ private[connect] class SparkConnectAnalyzeHandler(
def transformRelation(rel: proto.Relation) =
planner.transformRelation(rel, cachePlan = true)
+ def getDataFrameWithoutExecuting(rel: LogicalPlan): DataFrame = {
+ val qe = session.sessionState.executePlan(rel, CommandExecutionMode.SKIP)
+ if (!qe.isLazyAnalysis) qe.assertAnalyzed()
+ new Dataset[Row](qe, () => RowEncoder.encoderFor(qe.analyzed.schema))
Review Comment:
> depending on the construction of an encoder, is not for free
It is almost free in this case, right? It is saved as an encoderGenerator in
the class and will only be evaluated when it is needed and should therefore not
incur overhead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
