hvanhovell commented on code in PR #50605:
URL: https://github.com/apache/spark/pull/50605#discussion_r2068720711
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectAnalyzeHandler.scala:
##########
@@ -61,21 +64,24 @@ private[connect] class SparkConnectAnalyzeHandler(
def transformRelation(rel: proto.Relation) =
planner.transformRelation(rel, cachePlan = true)
+ def getDataFrameWithoutExecuting(rel: LogicalPlan): DataFrame = {
+ val qe = session.sessionState.executePlan(rel, CommandExecutionMode.SKIP)
+ if (!qe.isLazyAnalysis) qe.assertAnalyzed()
+ new Dataset[Row](qe, () => RowEncoder.encoderFor(qe.analyzed.schema))
Review Comment:
Why are we constructing a Dataset here? There is no need to do so. Just
return the `qe.analyzed.schema`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
