attilapiros commented on code in PR #50230: URL: https://github.com/apache/spark/pull/50230#discussion_r2070910587
########## core/src/main/java/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriter.java: ########## @@ -104,6 +105,14 @@ final class BypassMergeSortShuffleWriter<K, V> private long[] partitionLengths; /** Checksum calculator for each partition. Empty when shuffle checksum disabled. */ private final Checksum[] partitionChecksums; + /** + * Checksum calculator for each partition. Different from the above Checksum, + * RowBasedChecksum is independent of the input row order, which is used to + * detect whether different task attempts of the same partition produce different + * output data or not. + */ + private final RowBasedChecksum[] rowBasedChecksums; + private final SparkConf conf; Review Comment: This `conf` is not needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
