mridulm commented on code in PR #50230:
URL: https://github.com/apache/spark/pull/50230#discussion_r2040102976
##########
core/src/main/java/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriter.java:
##########
@@ -171,7 +182,11 @@ public void write(Iterator<Product2<K, V>> records) throws
IOException {
while (records.hasNext()) {
final Product2<K, V> record = records.next();
final K key = record._1();
- partitionWriters[partitioner.getPartition(key)].write(key,
record._2());
+ final int partitionId = partitioner.getPartition(key);
+ partitionWriters[partitionId].write(key, record._2());
+ if (rowBasedChecksums.length > 0) {
Review Comment:
We should consistently use either `null` to indicate checksum is disabled,
or `length == 0`/`isEmpty`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
