beliefer commented on PR #50552: URL: https://github.com/apache/spark/pull/50552#issuecomment-2840802415
This PR fix the issue for base class `OffsetWindowFunctionFrameBase`. So I think it is also fixed the potential bug even if the nth_value could support default value with non literal expression. `UnboundedOffsetWindowFunctionFrame` and `UnboundedPrecedingOffsetWindowFunctionFrame` do not apply `fillDefaultValue` if `absOffset > input.length`, so it seems safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
