zhengruifeng opened a new pull request, #50618:
URL: https://github.com/apache/spark/pull/50618
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Client side should update `client.thread_local.ml_caches` after deletion
### Why are the changes needed?
`client.thread_local.ml_caches` should not keep deleted objects, but
```
In [1]: from pyspark.ml.linalg import Vectors
...: from pyspark.ml.classification import *
...: from pyspark.ml.regression import *
...:
...: df = spark.createDataFrame([
...: (1.0, 2.0, Vectors.dense(1.0)),
...: (0.0, 2.0, Vectors.sparse(1, [], []))], ["label", "weight",
"features"])
...:
...: lr = LinearRegression(regParam=0.0, solver="normal")
...: model = lr.fit(df)
25/04/17 13:23:16 WARN Instrumentation: [15c70922] regParam is zero, which
might cause numerical instability and overfitting.
[--------------------------------------------------------------------------------]
0.00% Complete (0 Tasks running, 2s, Scanned
0.0[--------------------------------------------------------------------------------]
0.00% Complete (0 Tasks running, 2s, Scanned 0.025/04/17 13:23:18 WARN
InstanceBuilder: Failed to load implementation
from:dev.ludovic.netlib.lapack.JNILAPACK
[********************************************************************************]
100.00% Complete (0 Tasks running, 2s, Scanned
0[********************************************************************************]
100.00% Complete (0 Tasks running, 2s, Scanned 0
In [2]: spark.client.thread_local.ml_caches
Out[2]: {'e531e646-6f41-42ad-a9b1-1ce78e35c79c'}
In [3]: del model
In [4]: spark.client.thread_local.ml_caches
Out[4]: {'e531e646-6f41-42ad-a9b1-1ce78e35c79c'}
```
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
added test
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
