zhengruifeng commented on code in PR #50665:
URL: https://github.com/apache/spark/pull/50665#discussion_r2067767526
##########
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala:
##########
@@ -1316,9 +1316,14 @@ class LogisticRegressionModel private[spark] (
}
}
-
@Since("1.6.0")
object LogisticRegressionModel extends MLReadable[LogisticRegressionModel] {
+ case class Data(
Review Comment:
I don't know why it fails `MLSuite`, but we should not make it public.
It seems `private[spark]` can work.
https://github.com/apache/spark/pull/50760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
