WeichenXu123 commented on code in PR #50665:
URL: https://github.com/apache/spark/pull/50665#discussion_r2063663281
##########
mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala:
##########
@@ -169,6 +173,19 @@ abstract class MLWriter extends BaseReadWrite with Logging
{
saveImpl(path)
}
+ /**
+ * Saves the ML instances to the local file system path.
+ */
+ @throws[IOException]("If the input path already exists but overwrite is not
enabled.")
+ private[spark] def saveToLocal(path: String): Unit = {
Review Comment:
My concern is changing the base class might influence compatibility,
currently `saveToLocal` and `loadFromLocal` are only developing APIs and are
only used in Spark connect server for ML cache management.
So that I tend to keep current code.
once we decide to make them as public APIs, we can consider to make a better
API / Base class design.
thoughts ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
