cloud-fan commented on code in PR #50593: URL: https://github.com/apache/spark/pull/50593#discussion_r2057250098
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/ColumnDefinition.scala: ########## @@ -194,7 +194,10 @@ object ColumnDefinition { /** * A fake expression to hold the column/variable default value expression and its original SQL text. */ -case class DefaultValueExpression(child: Expression, originalSQL: String) +case class DefaultValueExpression( + child: Expression, + originalSQL: String, + analyzedChild: Option[Expression] = None) Review Comment: do we need to display it? we already display the optimized expression and the original SQL string. We can override `def stringArgs` to exclude this new field in EXPLAIN -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org