aokolnychyi commented on code in PR #50593:
URL: https://github.com/apache/spark/pull/50593#discussion_r2056618614
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -3997,6 +3997,19 @@ class Analyzer(override val catalogManager:
CatalogManager) extends RuleExecutor
c.markAsAnalyzed(AnalysisContext.get)
case c: KeepAnalyzedQuery if c.resolved =>
c.storeAnalyzedQuery()
+ case c: CreateTable if c.resolved =>
Review Comment:
I went for handling CREATE/REPLACE directly as these two commands convert
defaults to V2. There are a few other commands for dealing with variables that
also use `DefaultValueExpression`. I didn't handle them here as there is no
need to convert their defaults to V2. I can make this rule more generic by
calling `transformExpressions` on arbitrary commands and defining a separate
node pattern for `DefaultValueExpression`. It will be more generic but
complicated. I am not sure we need the extra complexity now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
