vladimirg-db commented on code in PR #50548: URL: https://github.com/apache/spark/pull/50548#discussion_r2054668941
########## sql/core/src/test/resources/sql-tests/analyzer-results/join-lateral.sql.out: ########## @@ -1209,7 +1201,7 @@ Project [c1#x, c2#x, count(1)#xL] SELECT * FROM t1, LATERAL (SELECT * FROM (SELECT COUNT(*) cnt FROM t2 WHERE t1.c1 = t2.c1) WHERE cnt = c1 - 1) -- !query analysis Project [c1#x, c2#x, cnt#xL] -+- LateralJoin lateral-subquery#x [c1#x && c1#x], Inner ++- LateralJoin lateral-subquery#x [c1#x], Inner Review Comment: Unfortunately we cannot do that, because this is part of implicit alias that can be referenced by users:  Otherwise existing queries would break. ########## sql/core/src/test/resources/sql-tests/analyzer-results/join-lateral.sql.out: ########## @@ -1209,7 +1201,7 @@ Project [c1#x, c2#x, count(1)#xL] SELECT * FROM t1, LATERAL (SELECT * FROM (SELECT COUNT(*) cnt FROM t2 WHERE t1.c1 = t2.c1) WHERE cnt = c1 - 1) -- !query analysis Project [c1#x, c2#x, cnt#xL] -+- LateralJoin lateral-subquery#x [c1#x && c1#x], Inner ++- LateralJoin lateral-subquery#x [c1#x], Inner Review Comment: Unfortunately we cannot do that, because this is part of implicit alias that can be referenced by users:  Otherwise existing queries would break. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
