AveryQi115 commented on code in PR #50548:
URL: https://github.com/apache/spark/pull/50548#discussion_r2054652763
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -2309,6 +2316,27 @@ class Analyzer(override val catalogManager:
CatalogManager) extends RuleExecutor
* Note: CTEs are handled in CTESubstitution.
*/
object ResolveSubquery extends Rule[LogicalPlan] {
+
+ /**
+ * Returns the outer scope attributes referenced in the subquery
expressions
+ * in current plan and the children of the current plan.
+ */
+ private def getOuterAttrsNeedToBePropagated(plan: LogicalPlan):
Seq[Expression] = {
Review Comment:
Better not as there are many other places in the Analyzer use
`SubExprUtils.getOuterReferences`. And I checked that we don't need this
`getOuterAttrsNeedToBePropagated` there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
