AveryQi115 commented on code in PR #50285:
URL: https://github.com/apache/spark/pull/50285#discussion_r2052940646


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala:
##########
@@ -67,6 +67,8 @@ abstract class PlanExpression[T <: QueryPlan[_]] extends 
Expression {
  *
  * @param plan: the subquery plan
  * @param outerAttrs: the outer references in the subquery plan
+ * @param nestedOuterAttrs: the outer references in the subquery plan that 
cannot be resolved

Review Comment:
   I was thinking that for correlations, we have nested correlations and non 
nested ones. So nestedOuterAttrs here is connected with nested correlations. 
Calling it as unresolvedOuterReferences will be misleading..
   
   But feel free to leave some suggestions if you have any idea about how to 
name it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to