AveryQi115 commented on code in PR #50285:
URL: https://github.com/apache/spark/pull/50285#discussion_r2045148936
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/DynamicPruning.scala:
##########
@@ -67,6 +67,14 @@ case class DynamicPruningSubquery(
copy()
}
+ override def withNewNestedOuterAttrs(
+ nestedOuterAttrs: Seq[Expression]
+ ): DynamicPruningSubquery = {
+ // DynamicPruningSubquery should not have nested outer attrs
+ assert(nestedOuterAttrs.isEmpty)
Review Comment:
As DynamicPruningSubquery is a kind of subquery generated by the system, I
don't think throw a user-facing message would provide clear guidance for the
user. I can throw an internalError here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
