yaooqinn commented on code in PR #50591: URL: https://github.com/apache/spark/pull/50591#discussion_r2045880283
########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala: ########## @@ -314,6 +314,7 @@ object JdbcUtils extends Logging with SQLConfHelper { metadata.putBoolean("isSigned", isSigned) metadata.putBoolean("isTimestampNTZ", isTimestampNTZ) metadata.putLong("scale", fieldScale) + metadata.putString("externalEngineTypeName", typeName) Review Comment: There could be a type conversion when a JDBC client gets the ResultSetMetaData from DB systems. It's not always the DB-engine type. Names like `jdbcType`/`jdbcClientType` might be more acurate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org