pan3793 commented on code in PR #50591: URL: https://github.com/apache/spark/pull/50591#discussion_r2044587298
########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala: ########## @@ -314,6 +314,7 @@ object JdbcUtils extends Logging with SQLConfHelper { metadata.putBoolean("isSigned", isSigned) metadata.putBoolean("isTimestampNTZ", isTimestampNTZ) metadata.putLong("scale", fieldScale) + metadata.putString("remoteTypeName", typeName) Review Comment: how about `originalTypeName`? "remote" is not always accurate as the JDBC data source also supports embedded RDBMS, i.e. H2, Derby. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org