ericm-db commented on code in PR #50572:
URL: https://github.com/apache/spark/pull/50572#discussion_r2040375476
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/state/StreamStreamJoinStatePartitionReader.scala:
##########
@@ -111,7 +111,7 @@ class StreamStreamJoinStatePartitionReader(
partition.sourceOptions.stateCheckpointLocation.toString,
partition.queryId, partition.sourceOptions.operatorId,
partition.sourceOptions.batchId + 1, -1, None)
- joinStateManager = new SymmetricHashJoinStateManager(
+ joinStateManager = SymmetricHashJoinStateManager(
Review Comment:
intentional?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/state/StateDataSource.scala:
##########
@@ -88,6 +88,7 @@ class StateDataSource extends TableProvider with
DataSourceRegister with Logging
val stateCheckpointLocation = sourceOptions.stateCheckpointLocation
try {
+ // SPARK-51779 TODO: Support stream-stream joisn with virtual column
families
Review Comment:
nit: Support stream-stream 'joins' with virtual column families
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
