zecookiez opened a new pull request, #50572:
URL: https://github.com/apache/spark/pull/50572
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
SPARK-51779
This PR includes the join operator's implementation of using virtual column
families for stream-stream joins. This approach avoids setting up and
concurrently managing four state stores, improving overall stability.
This feature is gated behind a config (not set by default)
`STREAMING_JOIN_STATE_FORMAT_VERSION` with version 3, and several new tests are
added. Some existing suites like StreamInnerJoinSuite and etc have been
augmented to test both with and without this new config.
State data source reader is out of scope for this PR and will be supported
at a later point.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
There are a lot of concurrency issues and complexities in managing four
state stores during join operations. With the introduction of virtual column
families to RocksDB state stores, we can combine these stores into one state
store.
This change should bring more stability to join operators, as managing this
store should be less complex than before. A lot of stream-stream join logic can
be reduced down as a result of this change too.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
new features, bug fixes, or other behavior changes. Documentation-only updates
are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No, but users can opt in to this by setting
`STREAMING_JOIN_STATE_FORMAT_VERSION` to version 3 for their queries.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions
for the consistent environment, and the instructions could accord to:
https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
A new trait for testing, `AlsoTestWithVirtualColumnFamilyJoins` is added and
used for StreamingJoinSuite, which adds testing options to verify join
behavior, both with and without the new join config turned on.
A new test is added in OperatorStateMetadataSuite to verify the join
operator correctly produces and writes MetadataV2 with the new config.
A new instance metric test is added in StateStoreInstanceMetricSuite to
verify the behavior of the new join config, since creating column families
force a new snapshot version upload.
Several new tests are added in StreamingJoinSuite:
- Verifies StateSchemaV3 writes correct key and value schemas for the join
operator
- Restarting streaming join queries with virtual column families resumes as
expected
- Join query using virtual column families with HDFS should fail
- Restart the join query and disabling the column family config should
trigger an exception
SymmetricHashJoinStateManagerSuite is also updated to test these changes,
but with the caveat numRow checks in the suite are skipped because RocksDB
state stores do not instantly update their metrics.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
