vladimirg-db commented on code in PR #50555:
URL: https://github.com/apache/spark/pull/50555#discussion_r2042241844
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/ViewResolver.scala:
##########
@@ -101,14 +108,16 @@ class ViewResolver(resolver: Resolver, catalogManager:
CatalogManager)
val prevContext = if (viewResolutionContextStack.isEmpty()) {
ViewResolutionContext(
nestedViewDepth = 0,
- maxNestedViewDepth = conf.maxNestedViewDepth
+ maxNestedViewDepth = conf.maxNestedViewDepth,
+ catalogAndNamespace = unresolvedView.desc.viewCatalogAndNamespace
Review Comment:
This duplication will quickly get annoying, let's not do that.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/BridgedRelationId.scala:
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.sql.catalyst.analysis.resolver
+
+import org.apache.spark.sql.catalyst.analysis.UnresolvedRelation
+
+/**
+ * The [[BridgedRelationId]] is a unique identifier for an unresolved relation
in the whole logical
+ * plan including all the nested views. It is used to lookup relations with
resolved metadata which
+ * were processed by the fixed-point. Storing [[catalogAndNamespace]] is
required to differentiate
Review Comment:
```suggestion
* were processed by the fixed-point when running two Analyzers in dual-run
mode. Storing [[catalogAndNamespace]] is required to differentiate
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
