mihailom-db commented on code in PR #50555:
URL: https://github.com/apache/spark/pull/50555#discussion_r2042226396
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/ViewResolver.scala:
##########
@@ -101,14 +108,16 @@ class ViewResolver(resolver: Resolver, catalogManager:
CatalogManager)
val prevContext = if (viewResolutionContextStack.isEmpty()) {
ViewResolutionContext(
nestedViewDepth = 0,
- maxNestedViewDepth = conf.maxNestedViewDepth
+ maxNestedViewDepth = conf.maxNestedViewDepth,
+ catalogAndNamespace = unresolvedView.desc.viewCatalogAndNamespace
Review Comment:
Yes, true. But we wanted to make sure that catalogAndNamespace are always
provided on construction of the `ViewResolutionContext`. We can only combine
the copy with this if statement. But that seems to make the code less readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
