cloud-fan commented on code in PR #50546:
URL: https://github.com/apache/spark/pull/50546#discussion_r2040663825
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala:
##########
@@ -220,18 +224,31 @@ object CTESubstitution extends Rule[LogicalPlan] {
errorClass = "RECURSIVE_CTE_WHEN_INLINING_IS_FORCED",
messageParameters = Map.empty)
}
- val resolvedCTERelations =
+
+ val tempCteDefs = ArrayBuffer.empty[CTERelationDef]
+ val resolvedCTERelations = if (recursiveCTERelationAncestor.isDefined)
{
+ resolveCTERelations(relations, isLegacy = false, forceInline,
outerCTEDefs, tempCteDefs,
Review Comment:
We should never inline inner CTEs within recursive CTE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
