cloud-fan commented on code in PR #50546:
URL: https://github.com/apache/spark/pull/50546#discussion_r2039394412
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala:
##########
@@ -202,14 +202,18 @@ object CTESubstitution extends Rule[LogicalPlan] {
* @param forceInline always inline the CTE relations if this is true
* @param outerCTEDefs already resolved outer CTE definitions with names
* @param cteDefs all accumulated CTE definitions
+ * @param recursiveCTERelationAncestor contains information of whether we
are in a recursive CTE,
+ * as well as what CTE that is.
* @return the plan where CTE substitution is applied and optionally the
last substituted `With`
* where CTE definitions will be gathered to
*/
private def traverseAndSubstituteCTE(
plan: LogicalPlan,
forceInline: Boolean,
outerCTEDefs: Seq[(String, CTERelationDef)],
- cteDefs: ArrayBuffer[CTERelationDef]): (LogicalPlan,
Option[LogicalPlan]) = {
+ cteDefs: ArrayBuffer[CTERelationDef],
+ recursiveCTERelationAncestor: Option[(String, CTERelationDef)]):
+ (LogicalPlan, Option[LogicalPlan]) = {
Review Comment:
```suggestion
recursiveCTERelationAncestor: Option[(String, CTERelationDef)]
): (LogicalPlan, Option[LogicalPlan]) = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
