gengliangwang commented on code in PR #50561:
URL: https://github.com/apache/spark/pull/50561#discussion_r2040433390
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableChange.java:
##########
@@ -787,4 +806,81 @@ public int hashCode() {
return Arrays.hashCode(clusteringColumns);
}
}
+
+ /** A TableChange to alter table and add a constraint. */
+ final class AddConstraint implements TableChange {
+ private final Constraint constraint;
+ private final boolean validate;
Review Comment:
TBH I am a bit confused on this one. Shall we make it simple and let the
external table catalog to keep trace the `validatedTableVersion`?
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableChange.java:
##########
@@ -787,4 +806,81 @@ public int hashCode() {
return Arrays.hashCode(clusteringColumns);
}
}
+
+ /** A TableChange to alter table and add a constraint. */
+ final class AddConstraint implements TableChange {
+ private final Constraint constraint;
+ private final boolean validate;
Review Comment:
TBH I am a bit confused on this one. Shall we make it simple and let the
external table catalog to track the `validatedTableVersion`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
