gengliangwang commented on code in PR #50561:
URL: https://github.com/apache/spark/pull/50561#discussion_r2040421291


##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableChange.java:
##########
@@ -297,6 +298,24 @@ public int hashCode() {
     }
   }
 
+  /**
+   * Create a TableChange for adding a new Table Constraint
+   */
+  static TableChange addConstraint(Constraint constraint, Boolean validate) {

Review Comment:
   Good catch. 
   Was following
   ```
   static TableChange deleteColumn(String[] fieldNames, Boolean ifExists)
   ```
   I think boolean makes more sense here. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to