ahshahid commented on PR #50033: URL: https://github.com/apache/spark/pull/50033#issuecomment-2785274203
Of course that is my personal view...and non binding as a non committer Regards Asif On Mon, Apr 7, 2025, 10:33 PM Asif Shahid ***@***.***> wrote: > I see. So let me ask one final question: > If say it's the first result task which has failed and is being processed > by event process thread, in this simplifed PR, will there be a window / > situation , where the query will be aborted? > I guess, yes? > in the PR which I have opened, that window is not there. > Now it's based on individual 's preference. > I would gravitate towards my PR , if it minimizes the abort. > > However if the simplified PR of yours also, ensure that window of abort is > completely absent, then the simplified PR of yours is preferable. > > On Mon, Apr 7, 2025, 10:25 PM Attila Zsolt Piros ***@***.***> > wrote: > >> No even in the simplified I just abort the stage when a revert would be >> needed. >> >> — >> Reply to this email directly, view it on GitHub >> <https://github.com/apache/spark/pull/50033#issuecomment-2785257669>, or >> unsubscribe >> <https://github.com/notifications/unsubscribe-auth/AC6XG2AFJT2CQYX4V464PHT2YNMT7AVCNFSM6AAAAABXSCDWSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBVGI2TONRWHE> >> . >> You are receiving this because you were mentioned.Message ID: >> ***@***.***> >> [image: attilapiros]*attilapiros* left a comment (apache/spark#50033) >> <https://github.com/apache/spark/pull/50033#issuecomment-2785257669> >> >> No even in the simplified I just abort the stage when a revert would be >> needed. >> >> — >> Reply to this email directly, view it on GitHub >> <https://github.com/apache/spark/pull/50033#issuecomment-2785257669>, or >> unsubscribe >> <https://github.com/notifications/unsubscribe-auth/AC6XG2AFJT2CQYX4V464PHT2YNMT7AVCNFSM6AAAAABXSCDWSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBVGI2TONRWHE> >> . >> You are receiving this because you were mentioned.Message ID: >> ***@***.***> >> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
