ahshahid commented on PR #50033: URL: https://github.com/apache/spark/pull/50033#issuecomment-2785178002
Also I am confused.. you said that in the simplified PR of yours, the problem of reversion of result tasks existed, implying that results could be wrong... Is that problem , solved in the simplified PR? On Mon, Apr 7, 2025, 9:08 PM Asif Shahid ***@***.***> wrote: > Will check it tomorrow... BTW if you take your change and the other PR > 51016.. and enable the ha test added in this pr of mine, Pls check if it > passes > > On Mon, Apr 7, 2025, 9:02 PM Attila Zsolt Piros ***@***.***> > wrote: > >> Please checkout >> https://github.com/attilapiros/spark/pull/8/files?diff=unified&w=1 >> >> Ignoring the whitespaces the production code is just 13 lines added to >> DAGScheduler and there is no new state introduced. >> So the change is much simpler and easier to reason about. >> >> — >> Reply to this email directly, view it on GitHub >> <https://github.com/apache/spark/pull/50033#issuecomment-2785163540>, or >> unsubscribe >> <https://github.com/notifications/unsubscribe-auth/AC6XG2DYORH7J3Q4W2FOH5L2YNC6PAVCNFSM6AAAAABXSCDWSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBVGE3DGNJUGA> >> . >> You are receiving this because you were mentioned.Message ID: >> ***@***.***> >> [image: attilapiros]*attilapiros* left a comment (apache/spark#50033) >> <https://github.com/apache/spark/pull/50033#issuecomment-2785163540> >> >> Please checkout >> https://github.com/attilapiros/spark/pull/8/files?diff=unified&w=1 >> >> Ignoring the whitespaces the production code is just 13 lines added to >> DAGScheduler and there is no new state introduced. >> So the change is much simpler and easier to reason about. >> >> — >> Reply to this email directly, view it on GitHub >> <https://github.com/apache/spark/pull/50033#issuecomment-2785163540>, or >> unsubscribe >> <https://github.com/notifications/unsubscribe-auth/AC6XG2DYORH7J3Q4W2FOH5L2YNC6PAVCNFSM6AAAAABXSCDWSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBVGE3DGNJUGA> >> . >> You are receiving this because you were mentioned.Message ID: >> ***@***.***> >> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
