HeartSaVioR commented on code in PR #50488:
URL: https://github.com/apache/spark/pull/50488#discussion_r2027834178
##########
python/pyspark/sql/streaming/list_state_client.py:
##########
@@ -143,7 +131,7 @@ def append_list(self, state_name: str, values: List[Tuple])
-> None:
self._stateful_processor_api_client._send_proto_message(message.SerializeToString())
- self._stateful_processor_api_client._send_arrow_state(self.schema,
values)
+ self._stateful_processor_api_client._send_list_state(self.schema,
values)
Review Comment:
Maybe I can double confirm with benchmarking and address the other parts.
This part I did the benchmark and we have to be backed by the number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
