bogao007 commented on code in PR #50488:
URL: https://github.com/apache/spark/pull/50488#discussion_r2027867499
##########
python/pyspark/sql/streaming/list_state_client.py:
##########
@@ -41,6 +41,7 @@ def __init__(
# A dictionary to store the mapping between list state name and a
tuple of pandas DataFrame
# and the index of the last row that was read.
self.pandas_df_dict: Dict[str, Tuple["PandasDataFrameLike", int]] = {}
Review Comment:
Is `pandas_df_dict` still being used anywhere?
##########
python/pyspark/sql/streaming/list_state_client.py:
##########
@@ -143,7 +131,7 @@ def append_list(self, state_name: str, values: List[Tuple])
-> None:
self._stateful_processor_api_client._send_proto_message(message.SerializeToString())
- self._stateful_processor_api_client._send_arrow_state(self.schema,
values)
+ self._stateful_processor_api_client._send_list_state(self.schema,
values)
Review Comment:
+1, we use the same framework for MapState as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
