cloud-fan commented on code in PR #50275:
URL: https://github.com/apache/spark/pull/50275#discussion_r2000240255
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2Writes.scala:
##########
@@ -125,7 +125,14 @@ object V2Writes extends Rule[LogicalPlan] with
PredicateHelper {
// for DataFrame API cases, same options are carried by both Command and
DataSourceV2Relation
// for DataFrameV2 API cases, options are only carried by Command
// for SQL cases, options are only carried by DataSourceV2Relation
- assert(commandOptions == dsOptions || commandOptions.isEmpty ||
dsOptions.isEmpty)
Review Comment:
The way we turn `CaseInsensitiveStringMap` to a scala Map is
`r.options.asScala.toMap`, I think we should change it to
`r.options.asCaseSensitiveMap.asScala.toMap` to be case preserving
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
