huaxingao commented on PR #50275: URL: https://github.com/apache/spark/pull/50275#issuecomment-2731192728
> shall we be case-preserving and do not lower case the keys when creating `DataSourceV2Relation`? When creating a [CaseInsensitiveStringMap](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Utils.scala#L117), the keys are changed to lower case in the constructor. This `dsOptions` is used to create [DataSourceV2Relation](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Utils.scala#L153C16-L153C36). Since DataSourceV2Relation.option is a CaseInsensitiveStringMap, I feel it's the correct behavior to change the key to lower case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
