liuzqt commented on code in PR #50273:
URL: https://github.com/apache/spark/pull/50273#discussion_r2004339184
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AQEShuffleReadExec.scala:
##########
@@ -37,10 +37,13 @@ import org.apache.spark.sql.vectorized.ColumnarBatch
* node during canonicalization.
* @param partitionSpecs The partition specs that defines the arrangement,
requires at least one
* partition.
+ * @param numEmptyPartitions Number of empty partitions. This is only present
when there is
+ * coalescing
*/
case class AQEShuffleReadExec private(
child: SparkPlan,
- partitionSpecs: Seq[ShufflePartitionSpec]) extends UnaryExecNode {
+ partitionSpecs: Seq[ShufflePartitionSpec],
+ numEmptyPartitions: Option[Int] = None) extends UnaryExecNode {
Review Comment:
Do you think we need to distinguish `None`(for non-coalesce
`AQEShuffleReadExec`) and `0`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
