cloud-fan commented on code in PR #50273:
URL: https://github.com/apache/spark/pull/50273#discussion_r2010173181
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AQEShuffleReadExec.scala:
##########
@@ -200,7 +200,14 @@ case class AQEShuffleReadExec private(
val numCoalescedPartitionsMetric = metrics("numCoalescedPartitions")
val x = partitionSpecs.count(isCoalescedSpec)
numCoalescedPartitionsMetric.set(x)
- driverAccumUpdates += numCoalescedPartitionsMetric.id -> x
+ val numEmptyPartitionsMetric = metrics("numEmptyPartitions")
+ val y = child match {
+ case s: ShuffleQueryStageExec =>
Review Comment:
We may not reach it for canonicalized plans or other unknown cases. Shall we
be conservative and add a `case _ => 0`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
