LuciferYang commented on PR #50396: URL: https://github.com/apache/spark/pull/50396#issuecomment-2760111680
> I leave my LGTM since it seems at least consistent with how it's done right now. But if we don't need a large change to have a separate module, I would also prefer that. Thank you for your response @HyukjinKwon I believe that, despite this pr not being perfect, we can merge it for now, at least so that the Maven test scenarios indicated in the pr description won't completely fail. Afterwards, I will try to refactor the modules. Since we are currently unsure about the scale and feasibility of the code changes involved in module refactoring, it may not be completed before the release of Apache Spark 4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
