vrozov commented on PR #50396: URL: https://github.com/apache/spark/pull/50396#issuecomment-2755772320
The approach where tests are skipped based on the build order does not sound like a good solution to me. Some contributors may not realize that running `build/mvn clean install -Phive` does not exercise all necessary tests and some tests are skipped. Those tests may still break when the directory is created. Overall build with a circular dependency (connect client depends on assembly to run tests and assembly depends on client to build the jar) is a no go. Why not to create a separate client test module that depends on assembly and move those problematic tests to the new module? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
